Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tornado 5 fixes in ThreadedClient #352

Merged
merged 2 commits into from
Mar 9, 2018
Merged

tornado 5 fixes in ThreadedClient #352

merged 2 commits into from
Mar 9, 2018

Commits on Mar 8, 2018

  1. ThreadedClient: schedule IOLoop.stop in IOLoop thread 

    calling stop doesn’t wake the IOLoop with asyncio (tornado 5)
    @minrk
    minrk committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    7b45731 View commit details
    Browse the repository at this point in the history

  2. threadsafety in IOLoopThread 

    - avoid instantiating an IOLoop outside the thread in which it will be used,
  which sometimes causes problems.
- ensure asyncio eventloop is defined in the thread, if asyncio might be in use
    @minrk
    minrk committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    64aca4d View commit details
    Browse the repository at this point in the history