Add setup() args for new pypi.org #357
Conversation
setup.py
Outdated
| 'Programming Language :: Python', | ||
| 'Programming Language :: Python :: 2.7', | ||
| 'Programming Language :: Python :: 3', | ||
| 'Programming Language :: Python :: 3.3', | ||
| 'Programming Language :: Python :: 3.4', | ||
| 'Programming Language :: Python :: 3.5', | ||
| 'Programming Language :: Python :: 3.6', |
There was a problem hiding this comment.
I feel like I harp on about this, but my preference is to use the 2 and 3 classifiers and leave the more specific ones out. They only get out of date, as these have.
The python_requires parameter, which I see you've also added, is a better way of conveying which minor versions it's meant to work with.
There was a problem hiding this comment.
Yeah, I went back and forth on this myself. I will go with your suggestion @takluyver.
setup.py
Outdated
| 'Intended Audience :: System Administrators', | ||
| 'Intended Audience :: Science/Research', | ||
| 'License :: OSI Approved :: BSD License', | ||
| 'Operating System :: MacOS', | ||
| 'Operating System :: Microsoft :: Windows', | ||
| 'Operating System :: POSIX :: Linux', |
There was a problem hiding this comment.
I'd expect it to work on any platform where Python and ZMQ are available, which is probably a much bigger group than these three. Maybe use Operating System :: OS Independent instead? Or leave it out altogether - I think OS-independent is the default assumption for Python modules.
setup.py
Outdated
| @@ -85,6 +98,7 @@ def run(self): | |||
| 'entrypoints', | |||
| 'tornado>=4.1', | |||
| ], | |||
| python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, <4', | |||
There was a problem hiding this comment.
I think we can be optimistic and remove '<4' here. Putting this here prevents people from even attempting to install the package with a hypothetical Python 4 without us making a new release.
|
@willingc great! I can release 5.2.3 with this after the above comments are addressed. |
setup.py
Outdated
| 'Intended Audience :: System Administrators', | ||
| 'Intended Audience :: Science/Research', | ||
| 'License :: OSI Approved :: BSD License', | ||
| 'Operating System :: Independent', |
There was a problem hiding this comment.
The spelling is Operating System :: OS Independent . Tautological, I know, but I think PyPI refuses uploads if the classifiers don't match this list.
|
Hang tight. I need to fix the version error for Python 2. |
setup.py
Outdated
| @@ -85,6 +92,7 @@ def run(self): | |||
| 'entrypoints', | |||
| 'tornado>=4.1', | |||
| ], | |||
| python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, <=4', | |||
There was a problem hiding this comment.
We can remove <=4. The rest is already correctly limiting to 2.7, 3.3+. This should be:
python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*',adding >=3.3 would exclude 2.7, since all of these conditions are AND-ed together.
There was a problem hiding this comment.
Good point. I need more coffee.
|
Thanks! |
https://packaging.python.org/tutorials/distributing-packages/#setup-args