Allow third-party kernels to get additional args #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes special treatment of IPython console so that other kernels can get command-line args. This doesn't allow the passing of flags, but does allow filenames, etc. Once this fix is in place, kernels can get these args via self.parent.extra_args
dsblank
added a commit
to Calysto/metakernel
that referenced
this pull request
Aug 28, 2018
… args; requires jupyter/jupyter_client#396; run_as_main can accept args and kwargs
|
@minrk @Carreau Do you see any possible problems with this? Currently, extra command-line args to the console are just discarded for non-ipython kernels. There is a potential issue that the current infrastructure doesn't allow sending flags to the console kernel, but this at least allows sending presumedly filenames. I guess code will have to be added to the kernels (including ipython) for running startup code. But that is a separate issue too. |
|
+1 to remove special casing. I'm willing to try that, and revert if there are issues. |
Carreau
approved these changes
Aug 30, 2018
|
We used to have some special parsing of kernel args (like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes special treatment of IPython console so that other kernels can get command-line args. This doesn't allow the passing of flags, but does allow filenames, etc. Once this fix is in place, kernels can get these args via self.parent.extra_args