Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pywin32 dependency #489

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Remove pywin32 dependency #489

merged 1 commit into from
Oct 18, 2019

Conversation

vidartf
Copy link
Contributor

@vidartf vidartf commented Oct 9, 2019

Its use was removed in #483, so we can drop it now.

Its use was removed in jupyter#483, so we can drop it now.
@SylvainCorlay
Copy link
Member

There is still a small comment about pywin32 here.

"""
# Create a security attributes struct that permits inheritance of the
# handle by new processes.
# FIXME: We can clean up this mess by requiring pywin32 for IPython.
class SECURITY_ATTRIBUTES(ctypes.Structure):
_fields_ = [ ("nLength", ctypes.c_int),
("lpSecurityDescriptor", ctypes.c_void_p),
("bInheritHandle", ctypes.c_int) ]

@vidartf
Copy link
Contributor Author

vidartf commented Oct 18, 2019

@SylvainCorlay Yes, but that has been around since before the dependency was added in #483, and should remain as it is.

@SylvainCorlay SylvainCorlay merged commit 73b83be into jupyter:5.x Oct 18, 2019
@vidartf vidartf deleted the patch-1 branch October 18, 2019 14:22
@vidartf
Copy link
Contributor Author

vidartf commented Oct 18, 2019

Note: If/when this gets released, the conda-forge feedstock can be put back to noarch as well, cc @minrk

@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/jupyter-client-6-0-0/3414/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants