-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that debug request/reply and events follow the DAP specification and document added messages #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainCorlay
force-pushed
the
debug-messages
branch
from
July 24, 2020 11:15
2c8dc84
to
38aabad
Compare
blink1073
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
SylvainCorlay
force-pushed
the
debug-messages
branch
from
July 24, 2020 11:42
38aabad
to
f4225ca
Compare
SylvainCorlay
force-pushed
the
debug-messages
branch
from
July 24, 2020 12:09
f4225ca
to
38d4c59
Compare
davidbrochart
approved these changes
Jul 24, 2020
SylvainCorlay
force-pushed
the
debug-messages
branch
2 times, most recently
from
July 24, 2020 14:45
3f14899
to
452bf46
Compare
…tion and document added messages
SylvainCorlay
force-pushed
the
debug-messages
branch
from
July 24, 2020 14:58
452bf46
to
054aa30
Compare
jtpio
reviewed
Jul 24, 2020
Looks good 👍 |
JohanMabille
approved these changes
Jul 24, 2020
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Now that jupyter/enhancement-proposals#47 is in, I think we can go ahead with this. |
Carreau
reviewed
Jul 27, 2020
Carreau
requested changes
Jul 27, 2020
Fixed the requested change by @Carreau. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf JEP on the Jupyter Debugger Protocol. jupyter/enhancement-proposals#47