Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that debug request/reply and events follow the DAP specification and document added messages #564

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

SylvainCorlay
Copy link
Member

Cf JEP on the Jupyter Debugger Protocol. jupyter/enhancement-proposals#47

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

docs/messaging.rst Outdated Show resolved Hide resolved
docs/messaging.rst Outdated Show resolved Hide resolved
docs/messaging.rst Outdated Show resolved Hide resolved
docs/messaging.rst Outdated Show resolved Hide resolved
docs/messaging.rst Outdated Show resolved Hide resolved
@SylvainCorlay SylvainCorlay force-pushed the debug-messages branch 2 times, most recently from 3f14899 to 452bf46 Compare July 24, 2020 14:45
docs/messaging.rst Outdated Show resolved Hide resolved
@jtpio
Copy link
Member

jtpio commented Jul 24, 2020

Looks good 👍

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@SylvainCorlay
Copy link
Member Author

Now that jupyter/enhancement-proposals#47 is in, I think we can go ahead with this.

docs/messaging.rst Outdated Show resolved Hide resolved
docs/messaging.rst Outdated Show resolved Hide resolved
@SylvainCorlay
Copy link
Member Author

Fixed the requested change by @Carreau.

@SylvainCorlay SylvainCorlay merged commit 778fa85 into jupyter:master Jul 28, 2020
@SylvainCorlay SylvainCorlay deleted the debug-messages branch July 28, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants