Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jedi<=0.17.2 #596

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Pin jedi<=0.17.2 #596

merged 1 commit into from
Jan 8, 2021

Conversation

davidbrochart
Copy link
Member

No description provided.

@davidbrochart davidbrochart merged commit 240271d into jupyter:master Jan 8, 2021
@davidbrochart davidbrochart deleted the pin_jedi branch January 8, 2021 10:32
@bollwyvl
Copy link
Contributor

bollwyvl commented Jan 8, 2021

This seems like kind of a bad play... what was the reasoning here?

This added a dependency which seems like not was is desired, but needs to be fixed at the actual import site of a downstream, e.g. ipython/ipython#12751.

At any rate, I don't think that version should stay... but this project could add it as a pin in its test requirements.

@davidbrochart
Copy link
Member Author

This seems like kind of a bad play... what was the reasoning here?

See https://github.com/jupyter/jupyter_client/runs/1667921500

This added a dependency which seems like not was is desired, but needs to be fixed at the actual import site of a downstream, e.g. ipython/ipython#12751.

At any rate, I don't think that version should stay... but this project could add it as a pin in its test requirements.

I agree.

@kaxil
Copy link

kaxil commented Jan 8, 2021

This has caused ripple effects in Apache Airflow (https://github.com/apache/airflow) as well. Are you planning to release a new version after removing the jedi from requirements? @davidbrochart

PS: I am the committer & PMC Member of Airflow project

@davidbrochart
Copy link
Member Author

Sorry for that, I just released 6.1.11 which should fix the issue.

@kaxil
Copy link

kaxil commented Jan 11, 2021

Sorry for that, I just released 6.1.11 which should fix the issue.

Thanks, appreciate the quick release 🙏

@minrk minrk mentioned this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants