Fix json_default so that it's closer to what ipykernel had before #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
fix_json_default
branch
from
8116d21 to
c9b01e2
Compare
martinRenou
force-pushed
the
fix_json_default
branch
3 times, most recently
from
b75aa86 to
52c2948
Compare
martinRenou
force-pushed
the
fix_json_default
branch
2 times, most recently
from
6ea90ee to
a3c2293
Compare
martinRenou
force-pushed
the
fix_json_default
branch
from
a3c2293 to
1131e31
Compare
davidbrochart
approved these changes
Sep 27, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipykernel's
json_cleanused to support generators, iterables, and int/float like types, this adds support for them