-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pending kernels #712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
approved these changes
Oct 18, 2021
Thanks @davidbrochart. I marked it as draft for discussion and because I still need to add tests for the new feature. |
8 tasks
blink1073
commented
Oct 21, 2021
TODO:
|
blink1073
force-pushed
the
pending-kernels
branch
from
October 25, 2021 12:42
17d3f8e
to
3c6e373
Compare
kevin-bates
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks Steve!
Thanks for the review! I'll make a release with this on Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MultiKernelManager.use_pending_kernels
to use a created kernel before the process has started, based on original discussion injupyter_server
.Add a
KernelManager.ready
property to that resolves when the process has started for the first time.Refuse to restart a kernel that has not been fully started - we could also decide to wait if it has been launched but not fully started.
Consumers using
use_pending_kernels
should wait for theready
future before attempting to communicate with the kernel.This change will correspond to a change in
jupyter_server
, where the server will use theready
future before connecting the websocket.Web clients will have to be updated to handle errors on WebSocket startup and surface them to the user.
As a result, the use of
use_pending_kernels
will be opt-in for now.MultiKernelManager.use_pending_kernels
KernelManager.ready
MultiKernelManager.shutdown_all
jupyter_server
- Use pending kernels jupyter-server/jupyter_server#593JupyterLab
- Fix Handling of WebSocket Startup Errors jupyterlab/jupyterlab#11358