Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json packer: handle TypeError and fallback to old json_clean #752

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Json packer: handle TypeError and fallback to old json_clean #752

merged 1 commit into from
Mar 7, 2022

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Mar 7, 2022 •
edited
Loading

TypeError are raised when the dictionaries contain invalid keys, which json_clean used to handle so we can fallback to it.

cc. @minrk

@blink1073 blink1073 added the bug label Mar 7, 2022
blink1073
blink1073 approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit c5c0b80 into jupyter:main Mar 7, 2022
@martinRenou martinRenou deleted the json_packer_handle_typeerror branch March 7, 2022 12:25
@martinRenou martinRenou mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @blink1073