Fix connection reconciliation to handle restarts #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
approved these changes
Nov 16, 2022
|
@meeseeksdev please backport to 7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter_client
that referenced
this pull request
Nov 16, 2022
blink1073
pushed a commit
that referenced
this pull request
Nov 16, 2022
…le restarts) (#883) Co-authored-by: Kevin Bates <kbates4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes delivered in #879 did not account for scenarios when ports have changed during restarts - which tends to occur with remote kernels. As a result, we need to reset the connection file when the connection information returned from the provisioner differs from the file's contents, rather than raise a
ValueError.Although this is probably not an issue in typical situations, it is something that should be fixed. I apologize to @blink1073 for having not caught this in my initial changes in #879 since two different releases were cut following those changes.