-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Qtconsole work with PyZMQ 25 #914
Make Qtconsole work with PyZMQ 25 #914
Conversation
It seems PyZMQ returns now a list of bytes and not a future, so this was not handled properly.
I'm also seeing this warning printed in the terminal when Qtconsole starts:
but I don't know how to fix it. |
Ok, I think this requires to merge first #482 to make the tests pass. Pinging @blink1073 and @minrk about it. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks @blink1073 for your help with this! It seems the ipykernel failure is caused by the new Qt eventloop integration, but I don't know how to fix it. |
For tracking, the change is zeromq/pyzmq#1785 which 'fixes' ZMQStream compatibility with async sockets (with a warning, because passing an async socket to ZMQStream indicates an odd mixture of async/sync APIs). ZMQStream never supported wrapping async sockets before pyzmq 25, but instead of raising it would fire callbacks with the wrong type (usually a Future instead of the message). Now, the The general fix that will work on all pyzmq versions is to ensure that ZMQStream is passed a regular zmq socket, which I believe was done in #835. |
main
branch.