ThreadedZMQStream: close stream before socket #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
changed the title
not just the underlying socket, because the stream represents event listeners on the socket, and can produce errors or at least warnings if the socket is closed before being unregistered
minrk
commented
Mar 16, 2023
|
|
||
| self.ioloop.add_callback(close_stream) | ||
| try: | ||
| f.result(timeout=5) |
There was a problem hiding this comment.
This pattern should prevent hangs in case of errors where we use Event.wait() without timeouts elsewhere in this file.
10 tasks
ccordoba12
reviewed
Mar 17, 2023
There was a problem hiding this comment.
Small fix in a docstring, the rest looks good to me. Thanks @minrk!
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
|
Thanks! I'll cut a release tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not just the underlying socket, because the stream represents event listeners on the socket, and can produce errors or at least warnings if the socket is closed before being unregistered. Or worst case, continue to register the wrong callbacks on a subsequent socket if it uses the freed FD before it's noticed.
related to spyder-ide/spyder#20381