Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean changelog heading #965

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Clean changelog heading #965

merged 2 commits into from
Oct 10, 2024

Conversation

krassowski
Copy link
Member

I think this may not be required, but apologies if it is. This currently renders as-is in the docs:

Screenshot from 2023-08-31 20-50-21

I believe jupyter-releaser uses <!-- <START NEW CHANGELOG ENTRY> --> markers, so I am not sure why this was included/retained.

@krassowski
Copy link
Member Author

@meeseeksdev tag bug

Copy link

lumberbot-app bot commented Nov 27, 2023

Awww, sorry krassowski you do not seem to be allowed to do that, please ask a repository maintainer.

@krassowski
Copy link
Member Author

@blink1073 I assume you are the maintainer in question ;) Would it help if the bot was allowed to label?

@blink1073
Copy link
Contributor

Would it help if the bot was allowed to label?

Yes, please, we can use the same config as Jupyterlab.

@krassowski
Copy link
Member Author

Anyone with rights to review?

Copy link
Member

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @krassowski.

@davidbrochart
Copy link
Member

But it looks I cannot merge 😞

@Carreau Carreau merged commit 79d3150 into jupyter:main Oct 10, 2024
28 of 31 checks passed
@krassowski
Copy link
Member Author

Thanks @Carreau for the merge and updating rights for me and @davidbrochart!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants