Avoid triggering extra logic in IPython.paths.get_ipython_dir when performing migration #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPython's get_ipython_dir always returns a writable directory that exists, creating one if the default resolution isn't writable.
We don't want to trigger all of this extra logic when checking for old config files to migrate,
so reimplement a simpler IPython dir resolution without any of IPython's own migration logic.
We already had a check if
get_ipython_dir()
exists to skip migration, but this would always be True because of upstreamget_ipython_dir()
's behavior.closes jupyterhub/jupyterhub#1503
It's also been long enough that we could consider removing automatic migration altogether, leaving only the explicit
jupyter-migrate
command.