Trigger warning when trying to check hidden file status on PyPy #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongrout
force-pushed
the
hiddenwarning
branch
from
48074c1
to
4082eb4
Compare
jasongrout
force-pushed
the
hiddenwarning
branch
from
4082eb4
to
38d5b0c
Compare
jasongrout
changed the title
jasongrout
force-pushed
the
hiddenwarning
branch
from
6ded5f3
to
a061c5a
Compare
|
@bollwyvl (or others) - can you review this? |
Closed
|
isn't this going to solve the problem ? https://foss.heptapod.net/pypy/pypy/-/issues/3469 |
It looks like it will in the next pypy release. Having this warning in will still help people that are on older releases, though. |
minrk
approved these changes
Sep 8, 2021
bollwyvl
reviewed
Sep 8, 2021
bollwyvl
reviewed
Sep 8, 2021
| @@ -275,6 +275,7 @@ def is_file_hidden_win(abs_path, stat_res=None): | |||
| # allow AttributeError on PyPy for Windows | |||
| # 'stat_result' object has no attribute 'st_file_attributes' | |||
| # https://foss.heptapod.net/pypy/pypy/-/issues/3469 | |||
| warnings.warn("hidden files are not detectable on this system, so no file will be marked as hidden.") | |||
There was a problem hiding this comment.
maybe we have/open a dedicated issue and link to it from here?
bollwyvl
approved these changes
Sep 8, 2021
|
LGTM, modulo the small docs items... but since we anticipate it being fixed upstream soon anyway... |
jasongrout
force-pushed
the
hiddenwarning
branch
from
3eb006a
to
c79b7e0
Compare
|
Thanks everyone for your comments and reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #235, perhaps the best thing to do to give best-effort support for pypy and help users to understand the current limitations is to trigger a warning when we know we cannot give good results.