migrate config at start of applications #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
write `.jupyter/migrated` to avoid re-running migration on every start
this seems to always be what we want
| # already migrated | ||
| return | ||
|
|
||
| ipdir = os.environ.get('IPYTHONDIR') or os.path.expanduser('~/.ipython') |
There was a problem hiding this comment.
We're importing/defining get_ipython_dir in the migrate module, should this import and use that rather than copying only the fallback logic?
|
Thanks, this looks good to me now. |
takluyver
added a commit
that referenced
this pull request
Jun 25, 2015
migrate config at start of applications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and shouldn't be rechecked