Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of config migration #356

Merged
merged 6 commits into from
Jun 14, 2023

Conversation

smartass101
Copy link
Contributor

better than just checking if it exists, because some on some platforms (e.g. ro AFS on HPC ) os.path.exists() may give False just because os.stat fails, even though the file actually exists

Also adds more test coveraate of the migrated marker checking

Fixes #355

Ondrej Grover and others added 2 commits June 13, 2023 09:20
better than just checking if it exists, because some on some
platforms (e.g. ro AFS on HPC ) os.path.exists() may give False just
because os.stat fails, even though the file actually exists

Also adds more test coveraate of the migrated marker checking

Fixes jupyter#355
@blink1073 blink1073 changed the title check if migrated marker is actually readable Better handling of config migration Jun 14, 2023
@blink1073 blink1073 added the bug label Jun 14, 2023
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 enabled auto-merge (squash) June 14, 2023 14:27
@blink1073 blink1073 merged commit c644219 into jupyter:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrated marker may seem not to exist if os.stat not allowed
2 participants