Lowercase APPNAME on macOS Homebrew #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singingwolfboy
force-pushed
the
homebrew-platformdirs
branch
from
5f04802
to
12e8a0a
Compare
|
Worth changing, but at least by default the filesystem is case preserving, but not case sensitive, in which case this is more of an aesthetic issue. (But it is at least possible to have case sensitive macOS filesystems.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of
platformdirscontains support for Homebrew-installed software, under the/opt/homebrewdirectory on macOS. In order for Jupyter to support this, we should also check to see if the Jupyter software is installed/managed by Homebrew on macOS, and if so, treat theAPPNAMEthe same way we do on Linux: lowercase, rather than capitalized.