Compatibility with IPython 8 where tracebacks are different #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzymadness
force-pushed
the
ipython8
branch
from
ddcf154 to
b88a38a
Compare
Comment on lines
+207
to
+211
| tb = [] | ||
| for line in output["traceback"]: | ||
| line = re.sub(ipython_input_pat, '<IPY-INPUT>', strip_ansi(line)) | ||
| line = re.sub(ipython8_input_pat, '<IPY-INPUT>', strip_ansi(line)) | ||
| tb.append(line) |
There was a problem hiding this comment.
Suggested change
| tb = [] | |
| for line in output["traceback"]: | |
| line = re.sub(ipython_input_pat, '<IPY-INPUT>', strip_ansi(line)) | |
| line = re.sub(ipython8_input_pat, '<IPY-INPUT>', strip_ansi(line)) | |
| tb.append(line) | |
| tb = [ | |
| re.sub(ipython8_input_pat, '<IPY-INPUT>', strip_ansi( | |
| re.sub(ipython_input_pat, '<IPY-INPUT>', strip_ansi(line)) | |
| ) | |
| for line in output['traceback'] | |
| ] |
There was a problem hiding this comment.
Well, honestly, my implementation seems to be more readable to me but it's your codebase so, if you want to, apply this suggestion. It might be also possible to merge the two regexes to one but again, readability would suffer.
There was a problem hiding this comment.
It was just a suggestion, I have no strong preference.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #189
We cannot use different regex for different IPython versions because the testing files contain the old form so we have to use them both. All tests are passing now with IPython 8.