-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if kernel is alive during cell execution #90
Conversation
I don't know about the failures, they are related to pyzmq and were already present in the last commit. |
The failing test is caused by the deprecation warning, I opened an issue in jupyter/jupyter_client#558. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I ran some papermill tests and calls and it seems solid. Thanks for tackling. Let's have the jupyter_client discussion on the issue you opened and make a decision about if we patch the test for now or get a change upstream made.
Looks like we got bitten by jupyter/jupyter_client#487:
Relaunching tests. |
@MSeal I will be AFK for a few days, I let you squash and merge if you think this is fine. |
Thanks so much for getting this fixed. I'll kick off a patch release. |
wahoo! 🥇 |
Fixes #88