Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if kernel is alive during cell execution #90

Merged
merged 7 commits into from
Jul 10, 2020
Merged

Check if kernel is alive during cell execution #90

merged 7 commits into from
Jul 10, 2020

Conversation

davidbrochart
Copy link
Member

Fixes #88

@davidbrochart
Copy link
Member Author

I don't know about the failures, they are related to pyzmq and were already present in the last commit.

@davidbrochart
Copy link
Member Author

The failing test is caused by the deprecation warning, I opened an issue in jupyter/jupyter_client#558.

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I ran some papermill tests and calls and it seems solid. Thanks for tackling. Let's have the jupyter_client discussion on the issue you opened and make a decision about if we patch the test for now or get a change upstream made.

@davidbrochart
Copy link
Member Author

Looks like we got bitten by jupyter/jupyter_client#487:

E         + Exception in thread Thread-3:
E         + Traceback (most recent call last):
E         +   File "/opt/hostedtoolcache/Python/3.8.3/x64/lib/python3.8/threading.py", line 932, in _bootstrap_inner
E         +     self.run()
E         +   File "/home/runner/work/nbclient/nbclient/.tox/py38/lib/python3.8/site-packages/ipykernel/heartbeat.py", line 93, in run
E         +     self._bind_socket()
E         +   File "/home/runner/work/nbclient/nbclient/.tox/py38/lib/python3.8/site-packages/ipykernel/heartbeat.py", line 74, in _bind_socket
E         +     self._try_bind_socket()
E         +   File "/home/runner/work/nbclient/nbclient/.tox/py38/lib/python3.8/site-packages/ipykernel/heartbeat.py", line 61, in _try_bind_socket
E         +     return self.socket.bind('%s://%s' % (self.transport, self.ip) + c + str(self.port))
E         +   File "zmq/backend/cython/socket.pyx", line 550, in zmq.backend.cython.socket.Socket.bind
E         +   File "zmq/backend/cython/checkrc.pxd", line 26, in zmq.backend.cython.checkrc._check_rc
E         + zmq.error.ZMQError: Address already in use

Relaunching tests.

@davidbrochart
Copy link
Member Author

@MSeal I will be AFK for a few days, I let you squash and merge if you think this is fine.

@MSeal MSeal merged commit 9750d91 into jupyter:master Jul 10, 2020
@MSeal
Copy link
Contributor

MSeal commented Jul 10, 2020

Thanks so much for getting this fixed. I'll kick off a patch release.

@choldgraf
Copy link
Contributor

wahoo! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nbclient waits indefinitely on killed subprocesses
3 participants