Fixed incorrect inkscape naming

jupyter · Jun 8, 2021 · f16c681 · f16c681
1 parent 7254202
commit f16c681
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/nbconvert/preprocessors/svg2pdf.py b/nbconvert/preprocessors/svg2pdf.py
@@ -87,10 +87,10 @@ def _command_default(self):
         if int(major_version) < 1:
             # --without-gui is only needed for inkscape 0.x
             command.append('--without-gui')
-            # --export-filename is old name for --export-pdf
-            command.append('--export-filename={to_filename}')
-        else:
+            # --export-pdf is old name for --export-filename
             command.append('--export-pdf={to_filename}')
+        else:
+            command.append('--export-filename={to_filename}')
 
         command.append('{from_filename}')
         return command

diff --git a/nbconvert/preprocessors/tests/test_svg2pdf.py b/nbconvert/preprocessors/tests/test_svg2pdf.py
@@ -90,14 +90,14 @@ def test_inkscape_pre_v1_command(self):
         assert preprocessor.command == [
             'fake-inkscape',
             '--without-gui',
-            '--export-filename={to_filename}',
+            '--export-pdf={to_filename}',
             '{from_filename}'
         ]
 
     def test_inkscape_v1_command(self):
         preprocessor = self.build_preprocessor(inkscape='fake-inkscape', inkscape_version='1.0beta2')
         assert preprocessor.command == [
             'fake-inkscape',
-            '--export-pdf={to_filename}',
+            '--export-filename={to_filename}',
             '{from_filename}'
         ]