Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tornado 6 compatibility #894

Closed
mrocklin opened this issue Oct 9, 2018 · 5 comments
Closed

Tornado 6 compatibility #894

mrocklin opened this issue Oct 9, 2018 · 5 comments
Milestone
5.4.1

Comments

@mrocklin
Copy link

mrocklin commented Oct 9, 2018

Note that as of Tornado 6 (still in development) the web.asynchronous decorator has left. This seems to break nbconvert

  File "/home/mrocklin/Software/anaconda/lib/python3.6/site-packages/nbconvert/postprocessors/serve.py", line 21, in ProxyHandler
    @web.asynchronous
AttributeError: module 'tornado.web' has no attribute 'asynchronous'
@jakirkham
Copy link
Member

Also seeing this with Tornado 6.0.1, which was recently released.

@stefanseefeld
Copy link

I just installed the whole software stack via pip3, now with Tornado 6.0.1 (no longer beta !), and still got the same error. FWIW.

@minrk
Copy link
Member

minrk commented Mar 6, 2019

This is fixed by #937 and released in nbconvert 5.4.1. Can you pip install --upgrade nbconvert?

@minrk minrk closed this as completed Mar 6, 2019
@minrk minrk added this to the 5.4.1 milestone Mar 6, 2019
@maartenbreddels maartenbreddels mentioned this issue Mar 7, 2019
Merged
@chrisjsewell chrisjsewell mentioned this issue Mar 7, 2019
Closed
@aglavers
Copy link

Confirming that conda install nbconvert=5.4.1 resolved this error

  File "/opt/conda/lib/python3.6/site-packages/nbconvert/postprocessors/serve.py", line 21, in ProxyHandler
    @web.asynchronous
AttributeError: module 'tornado.web' has no attribute 'asynchronous'

@jlstevens jlstevens mentioned this issue Mar 17, 2019
Merged
@jlstevens jlstevens mentioned this issue Apr 18, 2019
Closed
@meeseeksmachine
Copy link

This issue has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/kernel-does-not-start-in-jupyter-notebook-when-using-other-anaconda-environment-then-base/1952/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4.1
Development

No branches or pull requests
7 participants
@minrk @mrocklin @stefanseefeld @jakirkham @aglavers @meeseeksmachine and others