Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tornado < 6 #71

Closed
danieltomasz opened this issue Mar 7, 2019 · 2 comments · Fixed by #75
Closed

tornado < 6 #71

danieltomasz opened this issue Mar 7, 2019 · 2 comments · Fixed by #75
Labels
enhancement question

Comments

@danieltomasz
Copy link

Bug Report

ipypublish 0.9.4 has requirement tornado<6, but you'll have tornado 6.0.1 which is incompatible.

Describe the bug

Is there a reason to holding to previous tornado version?
@danieltomasz
Copy link
Author

danieltomasz commented Mar 7, 2019 •
edited
Loading

Sorry for putting it as a bug report, I cannot edit it now :(
This is for more python version support?

@chrisjsewell
Copy link
Owner

Hey Dan, it was due to this issue jupyter/nbconvert#894, which they appear to have recently fixed.
So I basically need to copy their fix into ipypublish/postprocessors/reveal_serve.py

@chrisjsewell chrisjsewell mentioned this issue Apr 18, 2019
Merged
chrisjsewell added a commit that referenced this issue Apr 18, 2019
@chrisjsewell
Add Sphinx extension for glossary referencing: ipypublish.sphinx.gls (
230b856 
#75)

- Added Sphinx extension for glossary referencing: `ipypublish.sphinx.gls`.
  See :ref:`sphinx_ext_gls`

- Added `ConvertBibGloss` post-processor,
  to convert a bibglossary to the required format

- Added notebook-level metadata options for `bibglossary` and `sphinx`
  (see :ref:`meta_doclevel_schema`)

- Large refactoring and improvements for test suite, particularly for testing
  of Sphinx extensions (using the Sphinx pytest fixtures) and creation of the
  `IpyTestApp` fixture

- fixes #71 

Back-compatibility breaking changes:

- renamed Sphinx notebook extension from
  `ipypublish.ipysphinx` to `ipypublish.sphinx.notebook`
  (see :ref:`sphinx_ext_notebook`)

- `ipypublish.postprocessors.base.IPyPostProcessor.run_postprocess`
  input signature changed (and consequently it has changes for all post-processors)

`v0.9`:

```python
   def run_postprocess(self, stream, filepath, resources):
      output_folder = filepath.parent
```

`v0.10`:

``` python
   def run_postprocess(self, stream, mimetype, filepath, resources):
      output_folder = filepath.parent
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Sphinx extension for glossary referencing: ipypublish.sphinx.gls chrisjsewell/ipypublish
2 participants
@chrisjsewell @danieltomasz