-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use conda on RTD #222
Use conda on RTD #222
Conversation
- ipykernel | ||
- numpydoc | ||
- pip: | ||
- nbsphinx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, I didn't know that this was possible.
b978839
to
127c28e
Compare
Now, unfortunately, it has merge conflicts. Have you tested this on RTD? |
f70d31f
to
f9829dd
Compare
Waiting for RTD build now, I'll ping back when I'm sure it works. |
Did the RTD build go OK? |
Sorry, lost track. It did not, looking into why, now... |
Lame, pandoc seems to not be loading libgmp... |
Marking back as WIP, since there always seems to be something going awry. |
Part of the problem seems to be caused by nbsphinx executing notebooks, which we don't want to happen on RTD. Is there a way to prevent that? |
so their output is stored, and nbsphinx doesn't try to run them
remove unused ipykernel, numpydoc
f9829dd
to
809cda5
Compare
It works! I just had to run locally and commit the output, to avoid nbsphinx trying to run it on RTD. One weird bit was that the pandoc conda package doesn't seem to work with python 3, due to a missing libgmp, but it works fine with Python 2. No idea why that would be, but it works now. |
I thought nbsphinx removed the need for pandoc to do this? |
The main point for using AFAICT, pandoc is still used via the Jinja filter |
Ah, right, I didn't realise that nbsphinx was converting notebooks to rst as an intermediate stage - I thought it was loading them directly into Sphinx, similar to what recommonmark (presumably) does for Markdown. |
OK, I tried this conda thing on readthedocs, but it didn't work and reported some errors. Then I tried it with plain old Isn't this good enough? Why do you even want to switch to conda? BTW, the dependency on |
That's the same error I got:
I think it comes about when the environment path, which includes the project name on RTD and the git branch name, is too long. So it should be fine in the main repo. See readthedocs/readthedocs.org#1902 for more details. If nbsphinx needs pandoc, how is it working with requirements.txt? |
Initially, I wanted to convert directly to the docutils format, but I didn't have enough experience then. At some point, I might consider re-implementing it without the detour, but currently that's not my plan.
I guess because pandoc is already installed on readthedocs? |
Huh, I guess it makes sense that pandoc is there, but I'm surprised we didn't spot it before. |
Any reason not to merge, then? |
Let's find out! |
I was a little bit too late to object ... I don't think that it's a good idea to add the manually created notebook outputs after removing the manually created The notebooks can be auto-executed on readthedocs perfectly fine without conda and without the need to commit any auto-generated bloat to the repository. As I've shown above. |
I added the outputs specifically because this wasn't working, and I don't think we want to be executing notebooks on RTD. |
Well it is working perfectly without conda, see #222 (comment).
OK, fair enough, but might I ask why? I think it would be great to execute the notebooks on RTD, because then it is assured that the documentation is up-to-date with the implementation. But probably I'm missing some disadvantages of executing them on RTD? |
continuation of #184