Fix buildSelect + tests

jupyter · Oct 5, 2021 · 33e9c67 · 33e9c67
1 parent d68aed3
commit 33e9c67
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/packages/nbdime/src/common/util.ts b/packages/nbdime/src/common/util.ts
@@ -298,7 +298,7 @@ function buildSelect(options: string[], select?: HTMLSelectElement): HTMLSelectE
   }
   for (let option of options) {
     let opt = document.createElement('option');
-    opt.value = opt.innerText = option;
+    opt.text = option;
     select.appendChild(opt);
   }
   return select;

diff --git a/packages/nbdime/test/src/common/util.spec.ts b/packages/nbdime/test/src/common/util.spec.ts
@@ -257,6 +257,36 @@ describe('common', () => {
 
     });
 
+    describe('buildSelect', () => {
+
+      it('should create an empty select', () => {
+        let value = util.buildSelect([]);
+        expect(value.outerHTML).toEqual("<select></select>");
+      });
+
+      it('should reuse a given select', () => {
+        const select = document.createElement('select');
+        let value = util.buildSelect([], select);
+        expect(value).toBe(select);
+      });
+
+      it('should create a select with options', () => {
+        let value = util.buildSelect([
+          'foo',
+          'bar',
+          '<div>boo</div>'
+        ]);
+        expect(value.outerHTML).toEqual(
+          '<select>' +
+            '<option>foo</option>' +
+            '<option>bar</option>' +
+            '<option>&lt;div&gt;boo&lt;/div&gt;</option>' +
+          '</select>'
+        );
+      });
+
+    });
+
   });
 
 });