Jupyter fails to start on Windows when runtime dir has an apostrophe or space in it #3409
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Update Playwright Snapshots | |
| on: | |
| issue_comment: | |
| types: [created, edited] | |
| permissions: | |
| contents: read | |
| jobs: | |
| update-snapshots: | |
| if: > | |
| ( | |
| github.event.issue.author_association == 'OWNER' || | |
| github.event.issue.author_association == 'COLLABORATOR' || | |
| github.event.issue.author_association == 'MEMBER' | |
| ) && github.event.issue.pull_request && ( | |
| contains(github.event.comment.body, 'please update playwright snapshots') || | |
| contains(github.event.comment.body, 'please update galata snapshots') || | |
| contains(github.event.comment.body, 'please update snapshots') | |
| ) | |
| runs-on: ubuntu-latest | |
| permissions: | |
| # Required by actions/update-snapshots | |
| contents: write | |
| pull-requests: write | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| browser: [firefox, chromium] | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| - name: React to the triggering comment | |
| run: | | |
| gh api repos/${{ github.repository }}/issues/comments/${{ github.event.comment.id }}/reactions --raw-field 'content=+1' | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Configure git to use https | |
| run: git config --global hub.protocol https | |
| - name: Get PR Info | |
| id: pr | |
| env: | |
| PR_NUMBER: ${{ github.event.issue.number }} | |
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| GH_REPO: ${{ github.repository }} | |
| COMMENT_AT: ${{ github.event.comment.created_at }} | |
| run: | | |
| pr="$(gh api /repos/${GH_REPO}/pulls/${PR_NUMBER})" | |
| head_sha="$(echo "$pr" | jq -r .head.sha)" | |
| pushed_at="$(echo "$pr" | jq -r .pushed_at)" | |
| if [[ $(date -d "$pushed_at" +%s) -gt $(date -d "$COMMENT_AT" +%s) ]]; then | |
| echo "Updating is not allowed because the PR was pushed to (at $pushed_at) after the triggering comment was issued (at $COMMENT_AT)" | |
| exit 1 | |
| fi | |
| echo "head_sha=$head_sha" >> $GITHUB_OUTPUT | |
| - name: Checkout the branch from the PR that triggered the job | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| run: gh pr checkout ${{ github.event.issue.number }} | |
| - name: Validate the fetched branch HEAD revision | |
| env: | |
| EXPECTED_SHA: ${{ steps.pr.outputs.head_sha }} | |
| run: | | |
| actual_sha="$(git rev-parse HEAD)" | |
| if [[ "$actual_sha" != "$EXPECTED_SHA" ]]; then | |
| echo "The HEAD of the checked out branch ($actual_sha) differs from the HEAD commit available at the time when trigger comment was submitted ($EXPECTED_SHA)" | |
| exit 1 | |
| fi | |
| - name: Base Setup | |
| uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 | |
| - name: Build | |
| uses: ./.github/actions/build-dist | |
| - uses: actions/download-artifact@v4 | |
| with: | |
| name: notebook-dist-${{ github.run_number }} | |
| path: ./dist | |
| - name: Install the package | |
| run: | | |
| cd dist | |
| python -m pip install -vv notebook*.whl | |
| # disable git hooks | |
| git config core.hooksPath no-hooks | |
| - name: Install the test dependencies | |
| run: | | |
| cd ui-tests | |
| jlpm | |
| jlpm playwright install | |
| - name: Update snapshots | |
| uses: jupyterlab/maintainer-tools/.github/actions/update-snapshots@v1 | |
| with: | |
| github_token: ${{ secrets.GITHUB_TOKEN }} | |
| npm_client: jlpm | |
| test_folder: ui-tests | |
| start_server_script: 'null' | |
| update_script: test:update --browser ${{ matrix.browser }} | |
| env: | |
| DEBUG: pw:webserver |