Skip to content

Commit

Permalink
Merge pull request #3031 from gnestor/edit-view-pdf
Browse files Browse the repository at this point in the history
Use `/files` prefix for PDF-like files
  • Loading branch information
takluyver authored Nov 10, 2017
2 parents bbf0ead + 009af0e commit c9a7795
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions notebook/static/tree/js/notebooklist.js
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,12 @@ define([
return model.mimetype === 'text/html'
|| includes_extension(model.path, viewable_extensions);
};

// Files like PDF that should be opened using `/files` prefix
NotebookList.prototype._is_pdflike = function(model) {
var pdflike_extensions = ['pdf'];
return includes_extension(model.path, pdflike_extensions);
};

/**
* Handles when any row selector checkbox is toggled.
Expand Down Expand Up @@ -732,6 +738,10 @@ define([
{
uri_prefix = 'view';
}
if (model.type === 'file' && this._is_pdflike(model))
{
uri_prefix = 'files';
}
if (model.type === 'file' && this._is_notebook(model))
{
uri_prefix = 'notebooks';
Expand Down

0 comments on commit c9a7795

Please sign in to comment.