Don't change title when busy

jupyter · Oct 17, 2016 · e820ca2 · e820ca2
1 parent e832689
commit e820ca2
Showing 1 changed file with 17 additions and 15 deletions.
diff --git a/notebook/static/notebook/js/notificationarea.js b/notebook/static/notebook/js/notificationarea.js
@@ -242,40 +242,42 @@ define([
             $kernel_ind_icon.attr('class','kernel_dead_icon').attr('title','Kernel Dead');
             knw.danger(short, undefined, showMsg);
         });
+
+        var change_favicon = function (src) {
+            var link = document.createElement('link'),
+                oldLink = document.getElementById('favicon');
+            link.id = 'favicon';
+            link.type = 'image/x-icon';
+            link.rel = 'shortcut icon';
+            link.href = oldLink.href.replace();
+            if (oldLink) document.head.removeChild(oldLink);
+            document.head.appendChild(link);
+        };
 
         this.events.on('kernel_starting.Kernel kernel_created.Session', function () {
-            window.document.title='(Starting) '+window.document.title;
+            // window.document.title='(Starting) '+window.document.title;
             $kernel_ind_icon.attr('class','kernel_busy_icon').attr('title','Kernel Busy');
             knw.set_message("Kernel starting, please wait...");
+            change_favicon('/static/base/images/favicon-busy.ico');
         });
 
         this.events.on('kernel_ready.Kernel', function () {
             that.save_widget.update_document_title();
             $kernel_ind_icon.attr('class','kernel_idle_icon').attr('title','Kernel Idle');
             knw.info("Kernel ready", 500);
+            change_favicon('/static/base/images/favicon.ico');
         });
-
-        var change_favicon = function (src) {
-            var link = document.createElement('link'),
-                oldLink = document.getElementById('favicon');
-            link.id = 'favicon';
-            link.type = 'image/x-icon';
-            link.rel = 'shortcut icon';
-            link.href = src;
-            if (oldLink) document.head.removeChild(oldLink);
-            document.head.appendChild(link);
-        };
 
         this.events.on('kernel_idle.Kernel', function () {
             that.save_widget.update_document_title();
             $kernel_ind_icon.attr('class','kernel_idle_icon').attr('title','Kernel Idle');
-            change_favicon('/static/base/images/favicon.ico' + '?=' + Math.random());
+            change_favicon('/static/base/images/favicon.ico');
         });
 
         this.events.on('kernel_busy.Kernel', function () {
-            window.document.title='(Busy) '+window.document.title;
+            // window.document.title='(Busy) '+window.document.title;
             $kernel_ind_icon.attr('class','kernel_busy_icon').attr('title','Kernel Busy');
-            change_favicon('/static/base/images/favicon-busy.ico' + '?=' + Math.random());
+            change_favicon('/static/base/images/favicon-busy.ico');
         });
 
         this.events.on('spec_match_found.Kernel', function (evt, data) {