file editor should warn if file changes on disk

[cancan101]

I have a file editor open for a certain file. That file changes on disk. There should be a warning of some sort in the web editor that this has happened to prevent saving over the modified data.

[minrk]

We already have exactly this check for notebooks, so doing the same for edit should be doable.

[unnamedplay-r]

Hi @minrk, I'd like to take on this issue. I'm a first time contributor here, so any pointers to relevant architecture for this issue would be great!

[minrk]

Hi @unnamedplay-r! The first step would be to look at how the notebook implements the check_last_modified logic. Then the task would be to copy the relevant bits of that (or refactor it a bit to make it re-usable) to where edit implements save.

[unnamedplay-r]

Thanks for the help here @minrk. I'll give it a whirl this weekend. Should pull requests be submitted as WIP's, or submit upon completion? I can't seem to find any documentation on pull requests.

[takluyver]

Submitting a WIP is fine, just let us know in the description.

…

On 15 Aug 2017 5:05 p.m., "Gabriel Ruiz" ***@***.***> wrote: Thanks for the help here @minrk <https://github.com/minrk>. I'll give it a whirl this weekend. Should pull requests be submitted as WIP's, or submit upon completion? I can't seem to find any documentation on pull requests. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2726 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUA9agvzgl3B0h8VfeGtKBYbRo_9PNhks5sYcHAgaJpZM4OuDIN> .

[jonalloub]

Hi, I'm @jonalloub, and I am new to contributions on open source software. I see that someone is already taking a stab at this problem, but since it is still open, can I take a stab at it as well?

[takluyver]

Hi @jonalloub! There's already an open PR for this (#2783), and it looks like it's still active, so it may be best to find another issue. We should try to help get that PR complete, though.