Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyterlab-myst does not render admonitions under nb7 #6915

Closed
parmentelat opened this issue Jun 12, 2023 · 4 comments · Fixed by #6921
Closed

jupyterlab-myst does not render admonitions under nb7 #6915

parmentelat opened this issue Jun 12, 2023 · 4 comments · Fixed by #6921
Labels
Milestone

Comments

@parmentelat
Copy link
Contributor

Describe the bug

the jupyterlab-myst extension does not work as expected in nb7

To Reproduce

Steps to reproduce the behavior:

  1. install jlab4 as released in pip
  2. install nb7 with pip install -U --pre notebook
  3. install jupyterlab-myst with
    pip install git+https://github.com/executablebooks/jupyterlab-myst.git@agoose77/feat-jupyterlab-v4
  4. create a notebook with a simple admonition
  5. open in jlab and check that the admonition renders properly
  6. open the same notebook in nb7, the admonition is not rendered

Expected behavior
the extension should behave the same under both envs

Screenshots

the view under jlab

image

under nb7

image

Desktop (please complete the following information):

  • OS: [e.g. iOS] MacOS & linux
  • Browser [e.g. chrome, safari] - chrome
  • Version [e.g. 22]

Additional context

https://discourse.jupyter.org/t/generic-question-about-jlab4-and-nb7/19846

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Jun 12, 2023
@jtpio
Copy link
Member

jtpio commented Jun 13, 2023

Thanks @parmentelat for the detailed report.

Is there an error in the browser dev tools console?

@parmentelat
Copy link
Contributor Author

yes indeed, and quite a few :)

like for the other issue #6914 I will try this again in a clean slate environment, and will then report the console errors

while doing so I will also be careful to not install any other extension, because I'm starting to believe I may have experienced unplanned interferences from others exts.

@jtpio
Copy link
Member

jtpio commented Jun 13, 2023

3. install jupyterlab-myst with
pip install git+https://github.com/executablebooks/jupyterlab-myst.git@agoose77/feat-jupyterlab-v4

ok I just checked locally and this indeed works in lab:

image

But not in Notebook 7:

image

The error in Notebook 7 is the following:

Shared module @jupyterlab/markdownviewer doesn't exist in shared scope default

@jtpio
Copy link
Member

jtpio commented Jun 14, 2023

This will likely be fixed #6921:

image

@jtpio jtpio added this to the 7.0 milestone Jun 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants