-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize the shell layout with the settings #6921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core customization functionality looks and works well.
Configuring the Voila preview with the following settings to open in the right area: {
"layout": {
"Voila-preview": {"area": "right"}
}
} voila-preview.mp4 |
This will also be useful to get the markdown preview, that we can add to the settings by default: layout-settings-markdown.mp4 |
bot please update playwright snapshots |
As discussed today at Notebook meeting, I opened an issue in JupyterLab to consider making the shell layout customization more generic between JupyterLab and Notebook 7: jupyterlab/jupyterlab#14685 It's not clear whether this can be addressed before the Notebook 7 final release, or if this should be considered for a future version. So marking this as ready, although happy to make further improvements to the docs in follow-up PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Customization works well. Tests and documentation look good as well. Thank you @jtpio.
Thanks @andrii-i for the review! |
Fixes #6688
Fixes #6386
Fixes #6915
type
to theshell.add()
calls if anyapi-change
GitHub label because theShell
namespace was renamed toINotebookShell
For now the page needs to be refreshed for the user layout to be effective.
layout-settings.mp4