Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Download converted documents with uploadable configuration #2413

Closed
wants to merge 34 commits into from
Closed

[WIP] Download converted documents with uploadable configuration #2413

wants to merge 34 commits into from

Commits on Feb 20, 2018

  1. create handler for nbconvert post

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    4588abc View commit details
    Browse the repository at this point in the history

  2. change post handler to expect a notebook in the passed in json

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    d197d4d View commit details
    Browse the repository at this point in the history

  3. Lots of changes to try to get the dialog to work

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    dc4bc76 View commit details
    Browse the repository at this point in the history

  4. actually downloads a file, unfortunately its not the converted file

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    fa2deb9 View commit details
    Browse the repository at this point in the history

  5. intermediate work on getting the zip and tar files to behave appropri… 

    …ately
    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    823e1dc View commit details
    Browse the repository at this point in the history

  6. tar now actually works

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    34a55b8 View commit details
    Browse the repository at this point in the history

  7. use raw XMLHttpRequest and cookie from utils._get_cookie, test with tar

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    7d3d688 View commit details
    Browse the repository at this point in the history

  8. Clean up files

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    a850366 View commit details
    Browse the repository at this point in the history

  9. nicer names for things, get rid of logs

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    2b700fc View commit details
    Browse the repository at this point in the history

  10. Add back compression to zip

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    d22436b View commit details
    Browse the repository at this point in the history

  11. clean up whitespace and lines in server

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    d946423 View commit details
    Browse the repository at this point in the history

  12. loop through options

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    d4503a4 View commit details
    Browse the repository at this point in the history

  13. use valid object structure

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    e0cff44 View commit details
    Browse the repository at this point in the history

  14. clean up js

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    9f01820 View commit details
    Browse the repository at this point in the history

  15. move custom download down the menu to be near Print preview

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    ac9aa24 View commit details
    Browse the repository at this point in the history

  16. removing post argument from API

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    720fb4d View commit details
    Browse the repository at this point in the history

  17. change handle to trigger in response to button press

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    b555ac5 View commit details
    Browse the repository at this point in the history

  18. use raw XMLHttpRequest and cookie from utils._get_cookie, test with tar

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    ec218ff View commit details
    Browse the repository at this point in the history

  19. match RFC5987 3.2 formatting for Content Disposition, prettify code

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    8e96ffb View commit details
    Browse the repository at this point in the history

  20. cleanup logs, prints, and comments

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    26d75de View commit details
    Browse the repository at this point in the history

  21. remove buffer from use as var name (python keyword conflict)

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    704844b View commit details
    Browse the repository at this point in the history

  22. return old get endpoint to its classic form

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    cda47c1 View commit details
    Browse the repository at this point in the history

  23. create nbconvert-service endpoint, takes no arguments, json with cont… 

    …entmodel, output format & config
    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    b9caeaf View commit details
    Browse the repository at this point in the history

  24. create contents model style json object for post request

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    6e62b25 View commit details
    Browse the repository at this point in the history

  25. point to the correct api, gather the needed resources in that for pas… 

    …sing to the json object
    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    935a176 View commit details
    Browse the repository at this point in the history

  26. reformat js for onSave to be more idiomatic & better presented

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    4f1cce5 View commit details
    Browse the repository at this point in the history

  27. Add SUPPORTED_METHODS class attributes, bring closer to previous code… 

    …base
    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    2ab6ab9 View commit details
    Browse the repository at this point in the history

  28. remove ES6 style anonymous functions

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    d39593b View commit details
    Browse the repository at this point in the history

  29. don't assign values to that directly, in case that triggers a race co… 

    …ndition
    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    b102783 View commit details
    Browse the repository at this point in the history

  30. improve POST endpoint to be /nbconvert; clean up unused code

    @mpacer
    mpacer committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    4a636b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2018

  1. Fixes for @rgbkrk's suggestions to make phantom tests pass 

    switch consts to var per
remove trailing commas
    @mpacer
    mpacer committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    74137ef View commit details
    Browse the repository at this point in the history

  2. improvements to the handler 

    - use Config object
- keep naming consistent with other Handlers
- use export_format instead of output_format, to match
NbConvert.export_format
- search configuration for export format and fallback to the json body
    @mpacer
    mpacer committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    e237b21 View commit details
    Browse the repository at this point in the history

  3. add tests for NbconvertConfigHandler 

    also, change name to NbconvertConfigHandler
    @mpacer
    mpacer committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    e4342c5 View commit details
    Browse the repository at this point in the history

  4. Fixes in displaying export_formats 

    - change the capitalization to match menu options
- add slides
- add translations back
Thanks @damianavila
    @mpacer
    mpacer committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    a804423 View commit details
    Browse the repository at this point in the history