Add 5.1.0 to changelog #2723
Merged
Add 5.1.0 to changelog #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Aug 3, 2017
docs/source/changelog.rst
Outdated
| - Include metadata when copying a cell (:ghpull:`2349`). | ||
| - Stop notebooks from command line (:ghpull:`2388`). | ||
| - Improve "View" and "Edit" file handling in dashboard (:ghpull:`2449`) and (:ghpull:`2402`). | ||
| - Load custom.js before ``app_initialized.NotebookApp`` is triggered (:ghpull:`2710`). |
There was a problem hiding this comment.
This is misleading. We haven't changed the order of loading things - instead we added a promise as a new mechanism to run code after the application is initialized.
docs/source/changelog.rst
Outdated
| - Add session-specific favicons (notebook, terminal, file) (:ghpull:`2452`). | ||
| - Add /api/shutdown handler (:ghpull:`2507`). | ||
| - Include metadata when copying a cell (:ghpull:`2349`). | ||
| - Stop notebooks from command line (:ghpull:`2388`). |
There was a problem hiding this comment.
I think it's clearer to say 'notebook servers'.
docs/source/changelog.rst
Outdated
| - Preliminary i18n implementation (:ghpull:`2140`). | ||
| - Expose URL with auth token in notebook UI (:ghpull:`2666`). | ||
| - Fix search background style (:ghpull:`2387`). | ||
| - List running notebooks with ``--allow-root`` (:ghpull:`2421`). |
There was a problem hiding this comment.
I think the point of this PR is that you can list running notebook servers without needing --allow-root, whereas previously it was doing that check when it wasn't necessary.
takluyver
reviewed
Aug 3, 2017
docs/source/changelog.rst
Outdated
| - Include metadata when copying a cell (:ghpull:`2349`). | ||
| - Stop notebook server from command line (:ghpull:`2388`). | ||
| - Improve "View" and "Edit" file handling in dashboard (:ghpull:`2449`) and (:ghpull:`2402`). | ||
| - Provide a Promise implementation for ``app_initialized.NotebookApp`` event (:ghpull:`2710`). |
There was a problem hiding this comment.
Better, but still not very clear. How about "Provide a promise to replace use of the app_initialized.NotebookApp event"?
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
--allow-root(check allow_root after calling super #2421)./filespath except for.htmland .svg` #2449) and (Specifycharset=UTF-8when serving non-base64 files #2402).app_initialized.NotebookAppis triggered (Add a promise for app_initialized event. #2710).--MappingKernelManager.cull_idle_timeout(Cull idle kernels #2215).See the 5.1 milestone on GitHub for a complete list of issues and pull requests involved in this release.