Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Play' icon for run-cell toolbar button #2922

Merged
merged 1 commit into from
May 28, 2020

Conversation

takluyver
Copy link
Member

Based on @ellisonbg's research in gh-2914, most tools with similar functionality to run a piece of code use either the 'play' icon, or something custom designed (RStudio and Spyder are in the latter camp).

The analogy with audio and video does suggest that 'step forward' is more similar to running one cell, but it's not clear whether users are actually thinking about it in those terms.

I'm opening this for discussion, not for immediate merge. cc @SylvainCorlay who originally changed it to 'step forward', and @ssanderson and @rgbkrk who discussed that PR (#201). Sylvain did say at the time that he had seen users confused by it.

Based on @ellisonbg's research in jupytergh-2914, most tools with similar
functionality to run a piece of code use either the 'play' icon, or
something custom designed (RStudio and Spyder are in the latter camp).

The analogy with audio and video does suggest that 'step forward' is
more similar to running one cell, but it's not clear that users
are actually thinking about it in those terms.

I'm opening this for discussion rather than for immediate merge.
@blink1073
Copy link
Contributor

For visual reference:

The proposal is to change from the current:

to:

@blink1073
Copy link
Contributor

Spyder's Run Cell Icon:

image

@blink1073
Copy link
Contributor

And RStudio:

image

@takluyver
Copy link
Member Author

Thanks @blink1073!

I hadn't noticed that Spyder's icon incorporates the 'step forward' icon until I saw it enlarged.

@ccordoba12
Copy link
Contributor

@SylvainCorlay designed our icons too.

@rgbkrk
Copy link
Member

rgbkrk commented Oct 12, 2017

Yeah I think we should go back to the play button.

@gnestor
Copy link
Contributor

gnestor commented Nov 1, 2017

Play button is more simple. If both jupyterlab and nteract are using it, then I think that is enough reason to switch to using it, too.

There is another discussion about adding a "restart and run all" button to the toolbar at #2965 and what the icon for that should be. The step-forward icon does imply "run and stop" whereas the play icon doesn't. Please chime in there 👍

@ellisonbg
Copy link
Contributor

I am in favor of the play button with no text. See #2965 for related points about toolbar design.

@Zsailer
Copy link
Member

Zsailer commented May 15, 2020

Circling back here, even if it's 2.5 years later 😆. Looks like everyone is in agreement!

I'll give this a couple of days to see if there is any objections—then, I'll plan to merge. Thanks, all!

@rgbkrk rgbkrk merged commit 6308e97 into jupyter:master May 28, 2020
@rgbkrk
Copy link
Member

rgbkrk commented May 28, 2020

Thanks for bumping this thread @Zsailer!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants