Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to eventually allow users to write widgets using backbone native views or d3 views or other drop-in replacements for
Backbone.View
using the DOM manipulation library of their choice.These replacements for backbone views share the main
View.el
attribute, which is a native DOM element. Hence it should be used to insert the widget view in the page generically rather thanView.$el
which is specific to jquery.Besides inserting the widget in the page, jquery is only used for some basic css styling and
$.proxy
.In this PR, I Widget.js I removed the jquery dependency in manager.js, and Widget.js.
In the very end, I do:
which I would like to move to a different file. The idea, is that anyone could define their own version of DOMWidgetView based on NativeView: