Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQuery dependency and backbone view #3

Closed
wants to merge 3 commits into from

Conversation

SylvainCorlay
Copy link
Member

I would like to eventually allow users to write widgets using backbone native views or d3 views or other drop-in replacements for Backbone.View using the DOM manipulation library of their choice.

These replacements for backbone views share the main View.el attribute, which is a native DOM element. Hence it should be used to insert the widget view in the page generically rather than View.$el which is specific to jquery.

Besides inserting the widget in the page, jquery is only used for some basic css styling and $.proxy.

In this PR, I Widget.js I removed the jquery dependency in manager.js, and Widget.js.

In the very end, I do:

var WidgetView = Backbone.View.extend(WidgetInterface);
var DOMWidgetView = WidgetView.extend(DOMWidgetInterface);

which I would like to move to a different file. The idea, is that anyone could define their own version of DOMWidgetView based on NativeView:

var NativeWidgetView = Backbone.NativeView.extend(WidgetInterface);
var NativeDOMWidgetView = NativeWidgetView.extend(DOMWidgetInterface);

@SylvainCorlay
Copy link
Member Author

@jdfreder will reopen after the widget split.

@SylvainCorlay SylvainCorlay deleted the Mixins branch April 30, 2015 21:18
svurens added a commit to svurens/notebook that referenced this pull request Aug 6, 2015
Now usable, autofocus, execute and hide.
jdfreder added a commit that referenced this pull request Oct 21, 2015
@minrk minrk modified the milestone: no action Dec 1, 2015
takluyver pushed a commit that referenced this pull request Oct 24, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants