flush iopub before sending restarting/dead status messages #3759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures in |
|
Yup, I think I mixed something up. Will fix. |
minrk
changed the title
to ensure (approximately) that all messages from the stopped kernel are delivered before the dead/restarting message
|
Still wip? |
minrk
changed the title
|
Should be fixed now |
|
Thanks! |
This was referenced Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to ensure (approximately) that all messages from the stopped kernel are delivered before the dead/restarting message
Since this event is triggered after a process has stopped, the only race is with messages waiting in zmq to be handled, so flushing the zmq stream should eliminate the race in all but the most pathological cases.
cc @jasongrout