Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adapting also log the version jupyter_client is expecting. #4034

Merged
merged 2 commits into from
Oct 10, 2018

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Sep 26, 2018

It's still (IMHO) unclear how the adaptation goes. Like does "adapting
to protocol X.Y.Z." mean the end-result is X.Y.Z or what you
got is X.Y.Z and it's X.Y.W after adaptation.

It's still (IMHO) unclear how the adaptation goes. Like does "adapting
to protocol X.Y.Z." mean the end-result is X.Y.Z or what you
got is X.Y.Z and it's X.Y.W after adaptation.
@blink1073
Copy link
Contributor

What if we said instead "adapting from protocol version XXX to YYY"? I agree that the message is confusing, I had no idea it meant which version we were adapting from.

@Carreau
Copy link
Member Author

Carreau commented Sep 26, 2018

"adapting from protocol version XXX to YYY"

Yeah, even that is ambiguous

adapting from protocol version XXX (kernel) to YYY (client) ?

@blink1073
Copy link
Contributor

Sounds good!

@Carreau
Copy link
Member Author

Carreau commented Sep 26, 2018

I've tried something from the github UI, let's see if it works.

@jasongrout
Copy link
Member

Thanks! That message looks a lot more understandable to me.

@minrk minrk added this to the 6.0 milestone Oct 10, 2018
@minrk minrk merged commit b663bf1 into jupyter:master Oct 10, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants