Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start working on ability to have async_start_kernel in KernelManagers. #4126

Closed
wants to merge 6 commits into from
Closed

Start working on ability to have async_start_kernel in KernelManagers. #4126

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41d6f19
Start working on ability to have async_start_kernel in KernelManagers.
Carreau Oct 20, 2018
80d4071
consistant naming
Carreau Oct 22, 2018
20bb0e3
try to handle async restart
Oct 26, 2018
b7e4d4b
Try to handle the case where restart_kernel is a coroutine
Carreau Oct 31, 2018
37ff8e1
Merge remote-tracking branch 'merced/async-kernelmanagers' into async…
Carreau Oct 31, 2018
c16b4aa
typo
Carreau Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions notebook/services/kernels/kernelmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,19 @@ def start_kernel(self, kernel_id=None, path=None, **kwargs):
if kernel_id is None:
if path is not None:
kwargs['cwd'] = self.cwd_for_path(path)
kernel_id = yield gen.maybe_future(
super(MappingKernelManager, self).start_kernel(**kwargs)
)

sup = super(MappingKernelManager, self)
async_sk = getattr(sup, 'async_start_kernel', None)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async_sk = getattr(sup, 'async_start_kernel', None)
async_sk = getattr(sup, 'start_kernel_async', None)

if async_sk is not None:
res = super().async_start_kernel(**kwargs)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res = super().async_start_kernel(**kwargs)
res = super().start_kernel_async(**kwargs)

else:
res = super().start_kernel(**kwargs)

if isinstance(res, str):
kernel_id = res
else:
kernel_id = yield res

self._kernel_connections[kernel_id] = 0
self.start_watching_activity(kernel_id)
self.log.info("Kernel started: %s" % kernel_id)
Expand Down