Fix regressions in 5.7.x #4513
Merged
Fix regressions in 5.7.x #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In testing jupyterlab/jupyterlab#6138, I also discovered a regression caused by #4412, where the async restart_kernel was not properly awaited. Instead, the Future was returned from the coroutine instead of the result of the future. |
minrk
changed the title
avoids issues with direct-checks for closed or closing sockets, which seems to change across tornado versions fixes some tornado 6 issues
gen.Return shouldn't be passed the Future, the future should be awaited
minrk
force-pushed
the
websocket-closed-forward
branch
from
d9afcb4 to
850eda5
Compare
|
Tests passed prior to rebase which fixed only the selenium and docs tests. Merging this so we can get 5.7.7 out. |
meeseeksmachine
pushed a commit
to meeseeksmachine/notebook
that referenced
this pull request
Mar 27, 2019
minrk
added a commit
that referenced
this pull request
Mar 27, 2019
…3-on-5.7.x Backport PR #4513 on branch 5.7.x (Fix regressions in 5.7.x)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some closed-socket issues with direct-checks for closed or closing sockets, which seems to change across tornado versions.
for backport to 5.7.x
debugging issues in jupyterlab/jupyterlab#6138