Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Pin preact and friends using ~ rather than ^. #4681

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

ssanderson
Copy link
Contributor

The most recent release of preact-compat appears to have broken notebook.

Fixes #4680.

The most recent release of preact-compat appears to have broken notebook.
@lresende
Copy link
Member

Do we know what in the new release of preact is causing the issues in Notebook? Should we actually look into making it compatible for the 6.0 release or folks think that the pin might be a good option for now? @minrk @blink1073

@blink1073
Copy link
Contributor

I'd say pin for now, I'm not as familiar with the frontend parts of this repo.

@lresende lresende added this to the 6.0 milestone Jun 24, 2019
@ssanderson
Copy link
Contributor Author

ssanderson commented Jun 24, 2019

I'm not super familiar with javascript packaging generally, but it looks to me like what happened is that the latest release of preact-compat added a new createContext method, which added a new dependency on preact-context, which we're not picking up properly.

I'm 100% spitballing here, but my guess is that the failure to pick up preact-context is related to the fact that we're using bower for package management, which doesn't know about the transitive dependencies of preact-compat (presumably b/c they don't have a bower.json?).

Assuming the above is correct, what this probably means is that any change that adds a new dependency to any of our bower-unaware dependencies (my guess is that's increasingly the majority of modern js projects given that bower seems to be EOL) will end up being a breaking change for us for as long as we're using bower to manage dependencies.

Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now as discussed above.

@lresende lresende merged commit 8d98489 into jupyter:master Jun 24, 2019
@takluyver takluyver mentioned this pull request Jun 25, 2019
blink1073 pushed a commit that referenced this pull request May 7, 2020
The most recent release of preact-compat appears to have broken notebook.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest preact-compat release breaks notebook.
3 participants