Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

russian i18n - 100% #5571

Merged
merged 9 commits into from
Jul 23, 2020
Merged

russian i18n - 100% #5571

merged 9 commits into from
Jul 23, 2020

Conversation

krotesk
Copy link
Contributor

@krotesk krotesk commented Jul 3, 2020

nbui.po - 100%
nbjs.po - 100%
notebook.po - 100%

@kevin-bates
Copy link
Member

Thank you for this great contribution. I'm adding a WIP label until you feel its at a merge point.

It would be much appreciated if others could review the translations as well!

@krotesk krotesk changed the title russian i18n - 5% russian i18n - 30% Jul 6, 2020
@krotesk
Copy link
Contributor Author

krotesk commented Jul 6, 2020

nbui.po - 100%
nbjs.po - 30%
notebook.po - 35%

@krotesk
Copy link
Contributor Author

krotesk commented Jul 9, 2020

nbjs.po - 100%

@krotesk krotesk changed the title russian i18n - 30% russian i18n - 100% Jul 9, 2020
@kevin-bates
Copy link
Member

Hi @krote5k - I've removed the WIP label with the assumption that this PR is ready for review. Thank you for adding this!

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @krote5k! 🇷🇺
Although I can't read Russian, the kinds of changes resemble the other translations.

@kevin-bates kevin-bates mentioned this pull request Jul 22, 2020
24 tasks
@blink1073 blink1073 merged commit 356966a into jupyter:master Jul 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants