-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update codemirror to 5.56.0+components1 #5637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Confirmed in local env. Thank you Jarrad!
The appveyor failure appears as though it encountered a network-related issue as it suddenly couldn't resolve github.com on the jquery entry in bower.json but I don't have restart privs. @Carreau - it looks like the appveyor project is under your account. Would you be able to provide me some "job-level" privileges so I have the ability to restart jobs? I pushed the same change to my fork yesterday and found similar behavior, although a re-build this morning was successful, so I'm proceeding with the merge since the appveyor issues appear unrelated. |
It look like both Carreau/notebook and Jupyter/notebook existed and were link to this repo, I've deleted mine, and hopefully this will let you see jupyter/notebook in PR and modify it ? |
Thanks Matthias. I still don't have privs for job control in appveyor - only in Travis CI. |
Ok, let's try another thing; you should have received invitation on your email(s), note that the lnk to appveyor in the PR status in PRs up until now will be wrong, so you might have to go manually to https://ci.appveyor.com/project/jupyter/notebook |
Beautiful - thank you. I can now see the job-control knobs. |
Great! Appveyor is still some kind of mystery to me !
…On Fri, Jul 31, 2020, 11:18 Kevin Bates ***@***.***> wrote:
Beautiful - thank you. I can now see the job-control knobs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5637 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACR5TYMH54S5TCPFCAEEHDR6MDG3ANCNFSM4PMTTEDQ>
.
|
This is a fixed re-release of 5.56.0.
Future CM upgrades should go back to the old pattern of e.g.
components/codemirror#~5.57.0
. (Note the~tilde) (I can't leave a comment to this effect in the JSON)
To fix #5629 .