Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable support for answer_yes flag #5941

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Re-enable support for answer_yes flag #5941

merged 1 commit into from
Jan 14, 2021

Conversation

afshin
Copy link
Member

@afshin afshin commented Jan 14, 2021

This fixes a bug. When user want's to shutdown the notebook server without confirmation, they should be able to call:

jupyter notebook -y

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @afshin!

The failing test is unrelated. Merging away!

@Zsailer Zsailer merged commit f6966e4 into jupyter:master Jan 14, 2021
@Zsailer
Copy link
Member

Zsailer commented Jan 14, 2021

We'll want to port this to jupyter_server, too, to address jupyter-server/jupyter_server#383

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants