Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind the HTTPServer in start #6061

Merged
merged 1 commit into from
May 13, 2021
Merged

Bind the HTTPServer in start #6061

merged 1 commit into from
May 13, 2021

Conversation

minrk
Copy link
Member

@minrk minrk commented May 13, 2021

Binding sockets hooks them up to the running eventloop, which we should try to avoid in initialize
in case any other stages may configure the event loop policy

This is ~equivalent to jupyter-server/jupyter_server#517 but in start instead of at the end of initialize.

I think calling listen in start is better, and easier because the bind was already a separate method call that was easy to move.

Binding sockets hooks them up to the running eventloop, which we should try to avoid in initialize
in case any other stages may configure the event loop policy
@blink1073 blink1073 added this to the 6.4 milestone May 13, 2021
@blink1073 blink1073 added the bug label May 13, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 80eb286 into jupyter:master May 13, 2021
@minrk minrk deleted the bind-in-start branch May 14, 2021 10:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants