Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CI error for python 3.6 & macOS #6215

Merged
merged 15 commits into from
Dec 24, 2021

Conversation

penguinolog
Copy link
Contributor

@penguinolog penguinolog commented Oct 25, 2021

Run actions/setup-python@v1
Error: Version 3.6 with arch x64 not found

Exclude nonexistent configurations from matrix

Run actions/setup-python@v1
Error: Version 3.6 with arch x64 not found
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Python 3.6 will be end-of-life in a month, should we take this opportunity to replace 3.6 with 3.10 in the CI matrix instead?

@penguinolog
Copy link
Contributor Author

penguinolog commented Nov 23, 2021 via email

@kevin-bates
Copy link
Member

@penguinolog, do you mind making the update to the test matrix that replaces 3.6 with 3.10?

@penguinolog
Copy link
Contributor Author

@penguinolog, do you mind making the update to the test matrix that replaces 3.6 with 3.10?

If main maintainers agree - I'll be happy

maliubiao and others added 11 commits December 20, 2021 21:07
* TST: don't look in user site for serverextensions
This is a fix for jupyter#6164

`nest_asyncio` must be applied before any async tasks have been created
otherwise there could be tasks queued that are unpatched, and thus do
not respect nested loops. An example of an unpatched task can be seen in
the original issue:

```
<Task pending coro=<HTTP1ServerConnection._server_request_loop() running at /apps/python3/lib/python3.7/site-packages/tornado/http1connection.py:823>
```
which originates from Tornado.

A similar issue was reported in `nest-asyncio`: erdewit/nest_asyncio#22
where the solution is to call `apply` on import so that unpatched tasks
do not get created.
* Automated Changelog Entry for 6.4.6 on master

* Update CHANGELOG.md

Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com>
SHA256 hashes:

notebook-6.4.6-py3-none-any.whl: 5cad068fa82cd4fb98d341c052100ed50cd69fbfb4118cb9b8ab5a346ef27551

notebook-6.4.6.tar.gz: 7bcdf79bd1cda534735bd9830d2cbedab4ee34d8fe1df6e7b946b3aab0902ba3
@penguinolog
Copy link
Contributor Author

@kevin-bates removed all python 3.6 links and replaced by python 3.10 (except tests -> it's still using lowest supported version)

@penguinolog
Copy link
Contributor Author

Python 3.6 is dead. Can we move forward?

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file changes look good to me, but I don't know what to make of the extraneous commits going on (not a GH expert enough to know if this is a concern).

Would @Zsailer or @blink1073 be able to take a look?

Also, since we probably shouldn't drop official support for 3.6 in a patch release, I'm going to open an issue for dropping 3.6 and adding 3.10 "officially".

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Final changes look good. A squash merge will take care of the extraneous commits.

@blink1073
Copy link
Contributor

I'm going to open an issue for dropping 3.6 and adding 3.10 "officially".

Yeah, agreed that should be a minor release.

@blink1073 blink1073 merged commit 8fd3ce9 into jupyter:master Dec 24, 2021
@penguinolog penguinolog deleted the ci_fix_not_supported branch December 25, 2021 19:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants