Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalise os_path #6540

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Normalise os_path #6540

merged 1 commit into from
Sep 25, 2022

Conversation

krassowski
Copy link
Member

@krassowski krassowski added the bug label Sep 13, 2022
@krassowski krassowski modified the milestones: 6.5, 6.4 Sep 13, 2022
@krassowski
Copy link
Member Author

Hi, could someone take a look at this and #6461? @echarles @RRosio? It fixes a regression preventing users from copying files (unless they enabled hidden files access).

echarles
echarles approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @krassowski

@echarles echarles merged commit 4fe291e into jupyter:6.5.x Sep 25, 2022
@echarles
Copy link
Member

echarles commented Sep 25, 2022 •
edited
Loading

I have merged:

Also the intent was to not release any new 6.4.x and invite users to migrate to 6.5. As we are still looking for feedbacks on 6.5 (see this blog post), I guess there is still room to cut a new 6.4.x.

@krassowski
Copy link
Member Author

I don't feel it is critical to backport these fixes to 6.4.x if 6.5.0 goes smoothly. I opened #6545 to forward port #6461.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@echarles echarles echarles approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@krassowski @echarles