-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renames Interface menu to "Open in", shortens menu options #6809
Conversation
bot please update playwright snapshots |
Thanks @JasonWeill for looking into this. Would it be possible to keep the longer form when the command is displayed in the command palette? With this change on Binder it doesn't seem possible to open with another interface via the command palette anymore: But it shows entry with |
Just as a hopefully helpful note: this can be implemented by using functional label testing for |
@krassowski I just pushed a change that adds a separate "short label" for use in the menu, making the longer "label" used in the command palette instead. When I built my changes locally, though, I still see the short label in both places. Can you please take a look? |
@krassowski Attempting to implement approach described by you in notebook PR #6847, in this commit but I'm missing a lot of details and could really use a consultation if/when you would have some time. Do I need to have a separate Edit: alternative approach where I register 2 commands with different labels but same functionality and assign one to the menu and one to the command palette seems to work (see #6847 Changed Files) |
Closing as fixed by #6847, thanks! |
Fix for #6806.
Renames the "Interface" menu to "Open in" and renames the commands to just the name of the desired interface.
In Notebook view:
In Lab view:
Note that the commands have particularly short names because Lumino doesn't yet allow custom menu item labels; see jupyterlab/lumino#570 .