Update README.md #7474
Update README.md #7474
Conversation
Steps to host Jpyter as web interface on Google, Mozilla etc.
|
|
|
Hello anyone there |
There was a problem hiding this comment.
These instructions are incorrect for a number of reasons:
- the port 8888 may be taken and a different port would be used instead
- usually there is no need to open a browser - the command above will open the default browser
localhostmay not work on specific systems and instead using 127.0.0.1 may be needed- the URL above will not include the token needed to login and this token will be different each time
Each PR should address an issue. This PR is not linked to any issue. In future I would encourage you to:
- open an issue first to discuss potential enhancements
- if you are looking for a way to contribute, looking through the issues and picking up something tagged as good first issue :)
|
Ok changed it a bit |
|
@krassowski can you check |
There was a problem hiding this comment.
I am still not convinced that this is an improvement over status quo. These instructions can be still misleading and usually none of these steps are necessary as a browser with the auto-generated temporary redirect file (which is also safer than typing in a token) will automatically open.
Maybe describing what would typically happen (that browser would open etc) and that if it does not then user should open and copy-paste URL could be more useful?
README.md
Outdated
| 1. Open a web browser (e.g., Google Chrome, Mozilla Firefox). | ||
| 2. Type: `http://localhost:'host number'` in the address baralong with the login token issued. | ||
| 3. Press Enter. |
Done changes as requested and fixed changes. PS: Please accept my first contribution.
Steps to host Jpyter as web interface on Google, Mozilla etc.