Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated function call to match API changes in jupyter_client #750

Closed
wants to merge 1 commit into from
Closed

Updated function call to match API changes in jupyter_client #750

wants to merge 1 commit into from

Conversation

captainsafia
Copy link
Member

If jupyter/jupyter_client#93 is merged, this should be merged in order to reflect the API changes in that PR.

@minrk
Copy link
Member

minrk commented Nov 24, 2015

@captainsafia that PR doesn't seem to remove the API previously used here, and removing that API would force a major-revision release on jupyter_client. I also don't see why this new API would be used, since it causes strictly more work to be done than the original find_kernel_specs.

@captainsafia
Copy link
Member Author

@minrk — Did you mean to put this in jupyter/jupyter_client#93? I'm a little bit confused as to what you mean.

@minrk
Copy link
Member

minrk commented Nov 24, 2015

No, I meant it to be here. This PR changes the dependency on jupyter_client to an unreleased version, and as far as I can tell from the jupyter_client PR, no benefit, since iterating through find_all_specs and find_kernel_specs has the same result and find_all_specs does strictly more work than find_kernel_specs. Perhaps there is something missing in this PR to actually make use of the difference between the two.

@minrk
Copy link
Member

minrk commented Dec 1, 2015

This can make sense if we also change the kernel_model call to allow passing the model from get_all_specs. But as it is, it doesn't make any use of the computed specs, it just discards them.

@minrk minrk added this to the 5.0 milestone Dec 1, 2015
@Carreau
Copy link
Member

Carreau commented Apr 7, 2016

Tagging as closed-PR, and closing as this is seem to have stalled a bit.
This is just to keep the PR queue a bit shorter and focusing on what is actually worked on.
Feel free to reopen, (or ask for reopening if you don't have enough right to do so).
If you were not the original author, and want to revive this, please feel free to do so.

Also, we are doing our best to enable people to learn how to contribute to the project, and get commits in. If you are missing time or have any other issues that prevent you to work on that, please feel free to tell us, we can try to build on top of what you did.

Thanks a lot and looking forward to see this moving forward again.

@Carreau Carreau closed this Apr 7, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants