-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple-undo for cell deletion #969
Conversation
use a stack for undelete_backup instead of a singleton avoids data loss on multiple undelete
+1 Excellent! Is this too extreme to backport into 4.x? The semester hasn't begun yet, so if it happened sooner than later, that would be a semester of happy students and instructors! |
Nice. This doesn't look too invasive, I think it would be reasonable to put it into a 4.x release. |
Fantastic, thanks. I will test the heck out of this. |
Hmm... I wonder if I ran into this:
I'm pretty sure that at least once I clicked in a cell though didn't change contents. |
selects [included,excluded) semi-open range, like Python conventions.
and test multi-cell undelete at both the top and bottom of the notebook
@minrk thanks, I've verified that your change fixes the problem for me. |
👍 for merge |
I think the easiest way (until developers handle this issue)to retrieve your Ipython history, write them all into an empty file and done! You need to check by the date you created your last script. Obviously, it is going to be the last part of your Ipython history. Good luck! To write your Ipython history into a file:
|
use a stack for undelete_backup instead of a singleton
avoids data loss on multiple undelete
Since this is only for undelete, it's possible for intermediate edits to prevent undeleted cells from going into the exact right place. But it's more important that the cells be recoverable than they be recovered to the exact right place every time.
closes #712
cc @fonnesbeck, who's been patiently waiting for this for ages.